Skip to content

Comments

4684 metadatablock localedisplayname#5290

Merged
kcondon merged 23 commits intoIQSS:developfrom
scholarsportal:4684-metadatablock-localedisplayname
Dec 17, 2018
Merged

4684 metadatablock localedisplayname#5290
kcondon merged 23 commits intoIQSS:developfrom
scholarsportal:4684-metadatablock-localedisplayname

Conversation

@JayanthyChengan
Copy link
Contributor

@JayanthyChengan JayanthyChengan commented Nov 7, 2018

Related Issues

Pull Request Checklist

  • Merged latest from "develop"

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 17.665% when pulling 86e5b7c on scholarsportal:4684-metadatablock-localedisplayname into 881694b on IQSS:develop.

@JayanthyChengan JayanthyChengan mentioned this pull request Nov 7, 2018
Closed
@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Nov 9, 2018 •
edited
Loading

@matthew-a-dunlap - checked-in all the changes related to this comment #5111 (review) . Please review

matthew-a-dunlap
matthew-a-dunlap reviewed Nov 13, 2018
View reviewed changes
Copy link
Contributor

@matthew-a-dunlap matthew-a-dunlap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JayanthyChengan This looks good, thanks for responding to my feedback! Is this pull request a replacement for #5111 ?

@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Nov 13, 2018

@matthew-a-dunlap - yes, it's replacement for #5111

@matthew-a-dunlap
Copy link
Contributor

matthew-a-dunlap commented Nov 13, 2018

@JayanthyChengan Ah great. Was the change to LocalBundle.java no longer needed?

@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Nov 13, 2018

I would like to do the changes to LocalBundle.java similar to BundleUtil.java .
Please refer: 8d4b2db

Can I do the changes to LocalBundle and submit in this PR , or do i need to open separate issue?

@scolapasta
Copy link
Contributor

scolapasta commented Nov 14, 2018 •
edited
Loading

@JayanthyChengan it's ok to do it as part of this one, assuming that's what you prefer.

@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Nov 15, 2018

@scolapasta committed LocalBundle.java

@JayanthyChengan
Copy link
Contributor Author

JayanthyChengan commented Nov 19, 2018

@scolapasta let me know for any other corrections after codereview.

@pameyer pameyer mentioned this pull request Nov 28, 2018
Closed
@kcondon kcondon merged commit ca40995 into IQSS:develop Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matthew-a-dunlap matthew-a-dunlap matthew-a-dunlap left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.10 - Additional Data Transfer Options

Development

Successfully merging this pull request may close these issues.

6 participants

@JayanthyChengan @coveralls @matthew-a-dunlap @scolapasta @pdurbin @kcondon