auth creds are based on bundle key, not value #5260#5306
Merged
Conversation
landreev
reviewed
Nov 15, 2018
Contributor
There was a problem hiding this comment.
Looks good.
Re: all the TODOs, about it being a bundle key; it is a little confusing. But I guess they way to think about it, it's not really a "bundle key"; it's an internal authentication framework key. And then we also use this key to store a label in the bundle; so that we can show a user-friendly label for it in human interfaces (such as the convert.xhtml page).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connects to #5260