Fixed #5340 delete auxiliary objects in Swift

[carlosmcgregor]

Change datafile storage identifier to work with joss
Change dataset storage identifier to reflect datafile storage identifier changes

Related Issues

• connects to deleteAllAuxObjects() fails on Swift due to malformed Swift REST API request #5340 : deleteAllAuxObjects() fails on Swift due to malformed Swift REST API request

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[coveralls]

Coverage decreased (-0.0003%) to 16.215% when pulling b1cf60f on carlosmcgregor:5340-delete-aux-fix into 0ee43fa on IQSS:develop.

[carlosmcgregor]

Added a few lines on a previously uncovered function -> coverage decreased.

[carlosmcgregor]

Hello @pdurbin ! In a conversation with @landreev we have opened a can of worms re: storageidentifier in the Swift driver. A brief summary would be the following:

• < 4.9.4 (presumed):
  • Example storageidentifier: swift://endpoint1:doi-10-1234-DM2-SZJXID:1673798809a-21f68803badb
  • Bug: Unknown
• 4.9.4:
  • Example storageidentifier: swift://endpoint1:doi-10-1234-DM2/SZJXID:1673798809a-21f68803badb
  • Bug: Unable to delete files
• 4.10:
  • Example storageidentifier: swift://endpoint1:doi-10-1234:DM2/SZJXID/1673798809a-21f68803badb
  • Bug: None

Given that 4.9.4's Swift driver was not production ready due to the inability to delete files, I would like your input on whether it would be necessary to investigate backward compatibility between 4.10 and < 4.9.4, and write a script to address any issue.

At a glance, I believe access to uploaded files would not be an issue. However, I would have to review on whether uploads become affected when working with already created datasets.

I apologize for bringing this to your attention so long after this PR!

[pdurbin]

@carlosmcgregor hi! If anyone is running any version of Dataverse before 4.10 and has trouble with Swift, we will just tell them to upgrade to the latest version of Dataverse. Thanks for the offer, though!

[pdurbin]

And thank you also for this great summary of what bugs existed when. It's easy for forget. I was having trouble helping a friend troubleshoot Swift yesterday at http://irclog.iq.harvard.edu/dataverse/2019-04-10#i_90842 and I was starting to wonder if Swift works at all. I asked at standup just now and it sounds like it does. And you're re-confirming that it works. (I believe I simply had auth misconfigured.) Thanks again for cracking open this Swift code and helping us improve it!

[carlosmcgregor]

@pdurbin Glad I could help! Looking forward to making further contributions :)

[pdurbin]

@carlosmcgregor great! The next one to maybe look at is #5754