-
Notifications
You must be signed in to change notification settings - Fork 535
update FilePIDsEnabled documentation #5395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kcondon
merged 3 commits into
IQSS:develop
from
uncch-rdmc:5394_Better_document_FilePIDsEnabled
Dec 17, 2018
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all makes sense to me. Much more clear and a better example. We could even add a note about file PIDs under "Decisions to Make" in a future version of http://guides.dataverse.org/en/4.9.4/installation/prep.html#decisions-to-make . It sounds like you don't like the default, out of the box setting to have file PIDs on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not that I disliked it, but rather the documentation describes the setting as optional. I found that, in its absence Dataverse assumes the setting to be true, so it's only-optional-if-you-disable-it. I was trying to make that more clear in the config page (Odum got 7 file PIDs by accident; I hadn't expected them as I hadn't purposefully set it to true)
I can update the verbage about registering DOIs, which as you point out lags behind recent changes in the DOI landscape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is a change in behavior, which I can see as being potentially confusing.