Closed
Conversation
pameyer
approved these changes
Dec 14, 2018
Contributor
pameyer
left a comment
pameyer
left a comment
There was a problem hiding this comment.
This looks good to me (tests pass, html validation results back not normal). Not moving to QA since review from others was requested.
Member
Author
|
@pameyer thanks but yes this shouldn't go to QA. I spoke with @scolapasta about it. It's a confusing situation but I'm sure it'll get sorted out eventually. |
Contributor
|
This PR appears to be a little premature. Removing the Vote to close. |
Member
Author
|
Closing in favor of pull request #5407. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5400