Style Guide: primary button is styled differently #5717#5917
Merged
mheppler merged 1 commit into5717-dialog-input-focusfrom Jun 10, 2019
Merged
Style Guide: primary button is styled differently #5717#5917mheppler merged 1 commit into5717-dialog-input-focusfrom
mheppler merged 1 commit into5717-dialog-input-focusfrom
Conversation
mheppler
approved these changes
Jun 10, 2019
Contributor
mheppler
left a comment
mheppler
left a comment
There was a problem hiding this comment.
Looks good. Will iterate some minor changes after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TaniaSchlatter and I just met and are suggesting adding to the Style Guide explaining how the primary button is styled differently. This is part of #5717.
I also adjusted the code sample below the button to make it look like a link as in the following screenshot.
@mheppler rather than stomping on your branch directly, this is a pull request for you to review and merge into your branch if you'd like.