Skip to content

Comments

5964 fixes flyway for gbr split#5966

Merged
kcondon merged 3 commits intodevelopfrom
5964-fixes-flyway-for-gbr-split
Jun 26, 2019
Merged

5964 fixes flyway for gbr split#5966
kcondon merged 3 commits intodevelopfrom
5964-fixes-flyway-for-gbr-split

Conversation

@landreev
Copy link
Contributor

@landreev landreev commented Jun 24, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.676% when pulling c1f533a on 5964-fixes-flyway-for-gbr-split into f5cc5d0 on develop.

@pdurbin pdurbin assigned landreev and unassigned pdurbin Jun 25, 2019
@pdurbin
Copy link
Member

pdurbin commented Jun 26, 2019

@landreev @scolapasta @sekmiller over at http://irclog.iq.harvard.edu/dataverse/2019-06-26#i_98757 @poikilotherm just asked if we've considered working on this issue:

Flyway: disable DDL generation from EclipseLink #5871

@pdurbin
Copy link
Member

pdurbin commented Jun 26, 2019

I just ran ec2-create-instance.sh -b 5964-fixes-flyway-for-gbr-split and 1fcb065 deployed just fine to EC2. Here's a screenshot:

Screen Shot 2019-06-26 at 8 55 54 AM

I'm eager to get deployments to phoenix working again because right now we can't run the API test suite so I'm dragging this to QA.

Screen Shot 2019-06-26 at 8 56 43 AM

Once again, there's a suggestion from @poikilotherm that we take a look at #5871 as a better solution. Or we could throw out all the Flyway stuff if it's driving us crazy. 😄

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploys to EC2 as of 1fcb065. Approved. I left a long comment at #5966 (comment)

@kcondon kcondon merged commit 2f477c9 into develop Jun 26, 2019
@kcondon kcondon deleted the 5964-fixes-flyway-for-gbr-split branch June 26, 2019 19:31
@kcondon kcondon self-assigned this Jun 26, 2019
pdurbin added a commit that referenced this pull request Jun 28, 2019
@djbrooke djbrooke added this to the 4.15.1 milestone Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

guestbookresponse table: "ERROR: column "downloadtype" does not exist" after pull request #5863 was merged

5 participants