Skip to content

6161 return basic search functionality#6164

Merged
kcondon merged 4 commits intodevelopfrom
6161-basic-search-functionality
Sep 12, 2019
Merged

6161 return basic search functionality#6164
kcondon merged 4 commits intodevelopfrom
6161-basic-search-functionality

Conversation

@sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Sep 12, 2019

fixes #6161

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!

Related Issues

Pull Request Checklist

  • Unit [tests][x] NA
  • Integration [tests][x]: None
  • Deployment requirements: None
  • Documentation NA
  • Merged latest from "develop" [branch][x] and resolved conflicts

@dataversebot
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage decreased (-0.0003%) to 19.472% when pulling 2d5b9f6 on 6161-basic-search-functionality into d8e3230 on develop.

@kcondon kcondon self-assigned this Sep 12, 2019
Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sekmiller!

@kcondon kcondon merged commit 9f41601 into develop Sep 12, 2019
@kcondon kcondon deleted the 6161-basic-search-functionality branch September 12, 2019 20:52
@djbrooke djbrooke added this to the 4.17 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search: Basic search stopped working in develop branch

7 participants