Skip to content

Comments

Force all edits to use command#6248

Merged
kcondon merged 2 commits intoIQSS:developfrom
QualitativeDataRepository:IQSS/alt6092
Oct 4, 2019
Merged

Force all edits to use command#6248
kcondon merged 2 commits intoIQSS:developfrom
QualitativeDataRepository:IQSS/alt6092

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Oct 2, 2019

Conflicts:
src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

Pull Request Checklist

Conflicts:
	src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java
@dataversebot
Copy link

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Oct 2, 2019

Coverage Status

Coverage increased (+0.02%) to 19.476% when pulling 5f7155e on QualitativeDataRepository:IQSS/alt6092 into df8dcf6 on IQSS:develop.

@qqmyers
Copy link
Member Author

qqmyers commented Oct 2, 2019

This is an alternative to #6094, per the discussion there, that removes the optimization logic that would route some file edits outside of any commands. I've tested making file-level metadata,tag,and provenance edits and think it is working as before. I did a quick time test and thing this version is slightly slower when editing one file in a dataset with 1000 files. (Not clear that's a fair comparison since I think #6094 includes indexing whereas this one now uses a command that does index after the call returns.) In any case, I think one of these two should get integrated since they fix an active bug (e.g. if you add a tag to a file, etc., the facets for sorting don't update)

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you get the latest from the Develop branch and resolve any conflicts?
Thanks!

@sekmiller sekmiller assigned qqmyers and unassigned sekmiller Oct 3, 2019
@kcondon kcondon merged commit 064f152 into IQSS:develop Oct 4, 2019
@kcondon kcondon self-assigned this Oct 4, 2019
@djbrooke djbrooke added this to the 4.18 milestone Oct 4, 2019
@qqmyers qqmyers deleted the IQSS/alt6092 branch May 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File metadata updates not reindexed

6 participants