Conversation
Conflicts: src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java
|
Can one of the admins verify this patch? |
|
This is an alternative to #6094, per the discussion there, that removes the optimization logic that would route some file edits outside of any commands. I've tested making file-level metadata,tag,and provenance edits and think it is working as before. I did a quick time test and thing this version is slightly slower when editing one file in a dataset with 1000 files. (Not clear that's a fair comparison since I think #6094 includes indexing whereas this one now uses a command that does index after the call returns.) In any case, I think one of these two should get integrated since they fix an active bug (e.g. if you add a tag to a file, etc., the facets for sorting don't update) |
sekmiller
left a comment
There was a problem hiding this comment.
Looks good. Can you get the latest from the Develop branch and resolve any conflicts?
Thanks!
Conflicts:
src/main/java/edu/harvard/iq/dataverse/EditDatafilesPage.java
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.
Thanks for your contribution to Dataverse!
Related Issues
Pull Request Checklist