6109 dataset summary cleanup

[mheppler]

Related Issues

• closes Metadata Labels - Review use of label tag outside of form (viewMode) #6109 Metadata Labels - Review use of label tag outside of form (viewMode)

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[dataversebot]

Can one of the admins verify this patch?

[coveralls]

Coverage increased (+0.001%) to 19.476% when pulling 2859648 on 6109-dataset-summary-cleanup into e5ecef3 on develop.

[sekmiller]

Does it matter that there's still a <label... for Host Dataverse and Template when you're in create mode? (around line 506 and 522 in dataset.xhtml.)

[mheppler]

@sekmiller Good question. Thank you for looking at the PR with that level of detail. The label components is appropriate in that case, on the edit/create modes of the pg. In the form, the labels with their for="{COMPONENT_ID}" attributes, have the corresponding input, select menu components with id={COMPONENT_ID} attributes.

There are other accessibility issues to address on the dataset pg edit/create form, and we can address those in another issue.

[sekmiller]

@mheppler It's such a big change that I wanted to make sure I understood what was going on. It looks good so I'm going to pass it along.