Make MDC DataCite URl configurable

[qqmyers]

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

• closes MakeDataCountApi is hardcoded to production datacite server #6137 MakeDataCountApi is hardcoded to production datacite server

Pull Request Checklist

• Unit tests completed
• Integration tests: None
• Deployment requirements, SQL updates, Solr updates, etc.: None
• Documentation completed
• Merged latest from "develop" branch and resolved conflicts

[dataversebot]

Can one of the admins verify this patch?

[coveralls]

Coverage decreased (-0.01%) to 19.462% when pulling 4bf2ad2 on QualitativeDataRepository:IQSS/6137 into 3bf9091 on IQSS:develop.

[pdurbin]

Looks good so I'm passing to QA but there's a fair amount to test here (not that that's bad, just sayin'):

• The installer has been updated.
• A new JVM option has been added.
• docker-aio has been updated (used for testing the JVM option, I assume)
• The docs have been updated.

I didn't build or test any of the above but all the changes make sense to me.

I guess my only feedback for @qqmyers is that it might be nice to update the Make Data Count documentation, maybe in the Admin Guide or the Dev Guide to mention the new JVM option. Both guides have pages on Make Data Count.

[kcondon]

@qqmyers @pdurbin

./install
String found where operator expected at ./install line 146, near "'DOI_MDCBASEURL'"
(Missing semicolon on previous line?)
String found where operator expected at ./install line 175, near "'DOI_MDCBASEURL'"
(Missing semicolon on previous line?)
syntax error at ./install line 146, near "'DOI_MDCBASEURL'"
syntax error at ./install line 175, near "'DOI_MDCBASEURL'"
Execution of ./install aborted due to compilation errors.

[pdurbin]

run tests

[kcondon]

I have built and checked the docs, tested the endpoints. Had trouble running the installation script -think it may just be missing a , when adding an addition element to list. Have not checked whether Dataverse actually uses the new MDC setting.

[pdurbin]

Yeah, it looks like there may be two places in the Perl script where commas are missing.

[djbrooke]

Thanks @qqmyers. Ready for us to take another look?

[qqmyers]

@djbrooke - Yep. BTW - When the fix is pretty obvious as it was here (two commas), you guys should feel free to make the change and keep going. (You're welcome to edit any time but here it definitely seems like more effort to document the issue, reassign, wait, etc.) I'm happy to support PRs when that makes less work for you guys, but no need for more work either.

[djbrooke]

Thanks @qqmyers, I'll try to do a better job keeping on top of when small changes need to be done and having us do them.

[pdurbin]

@qqmyers I'm going to work on one such small change. @kcondon requested some logging.

Also, a little bird told me that there's a bug in the changes to the Perl script. 😄

Thanks, as always, for hacking on Dataverse! 🎉

[kcondon]

@qqmyers @pdurbin

installer:
-JVM option name transposed: mdcbaseurl is set as basemdcurl instead.
-Default installation value for mdcbaseurl is not set (empty), need to also set the gfish env value.

Jim, are you able to test run the installer on your end?

Phil, thanks for adding the logger so I can check which url is used.

[qqmyers]

@kcondon - just updated the naming for the jvm option. (the api code was also different). I'm not really able to run the installer - really working on our branch and using the auto build/deploy process we have so I'm really guessing on changes to the various scripts.
W.r.t. a default value - I made it backwards compatible, so if you don't set it, the hardcoded value from earlier versions are used. If that's removed, the update instructions will need to include the step to set it.

[qqmyers]

@pdurbin - thanks for adding logging, and, as for hacking on Dataverse, at least you get a T-shirt this month :-)

[landreev]

For the main installer script to work, could you please add the following 2 lines to scripts/installer/install, at line 1104:

    $ENV{'DOI_BASEURL'} = $CONFIG_DEFAULTS{'DOI_BASEURL'};
    $ENV{'DOI_MDCBASEURL'} = $CONFIG_DEFAULTS{'DOI_MDCBASEURL'};

(it was missing it for the DOI_BASEURL variable too, yes;)

I would do it myself, but the branch is in your repository.
Thanks.

[pdurbin]

I would do it myself, but the branch is in your repository.

Yeah, I got "ERROR: Permission to QualitativeDataRepository/dataverse.git denied to pdurbin." when I tried to git push QualitativeDataRepository IQSS/6137 (which is fine) so I just created this pull request: QualitativeDataRepository#26

I haven't looked at the Perl script yet and don't plan to unless someone wants me to.

[pdurbin]

Sorry, it is WAY to easy to accidentally close a pull request. Re-opened! I mis-clicked. 😞

[pdurbin]

@kcondon in order to bump up the logging to see "Requesting citations from https://api.datacite.org/events?doi=10.5072/FK2/BL2IBM&source=crossref" (or whatever) in server.log, you can run this:

asadmin set-log-levels edu.harvard.iq.dataverse.api.MakeDataCountApi=FINE

[qqmyers]

Hmm - it's supposed to work. When I create the PRs I check the box to allow editing as in

This image is a test where I was tried our v4.17-qdr branch and you can see it says people with write on IQSS/dataverse (not QDR/dataverse) can commit to the branch in the PR. Could it be only by editing in the github website?

[djbrooke]

@qqmyers FWIW I tried update two weeks ago what I eventually mentioned in #6265 (comment) and was also denied. I assumed it was due to me being not good at Github. :) Sorry, I should have raised the flag then.