Skip to content

Comments

6278 fixes broken tab download#6304

Merged
kcondon merged 7 commits intodevelopfrom
6278-broken-tab-download
Oct 23, 2019
Merged

6278 fixes broken tab download#6304
kcondon merged 7 commits intodevelopfrom
6278-broken-tab-download

Conversation

@landreev
Copy link
Contributor

New Contributors

This fixes the tab download issue introduced in #6244; there's also a minor cleanup of the API messages/return codes

Related Issues

Pull Request Checklist

@coveralls
Copy link

coveralls commented Oct 22, 2019

Coverage Status

Coverage decreased (-0.007%) to 19.456% when pulling e4f0c30 on 6278-broken-tab-download into dbb145c on develop.

@djbrooke
Copy link
Contributor

@landreev, is this one ready for review?

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add AccessIT to the test suite. I'm happy to do it.

@djbrooke
Copy link
Contributor

Thanks @pdurbin.

@landreev, my bad if I added this to the code review column prematurely. I went to do it, then I thought I'd ask instead, but it looks like I added it. Sorry!

@landreev
Copy link
Contributor Author

Thanks @pdurbin.

@landreev, my bad if I added this to the code review column prematurely. I went to do it, then I thought I'd ask instead, but it looks like I added it. Sorry!

No, it was all good - I put it into code review myself yesterday.
It's almost done at this point.

@kcondon kcondon merged commit deb180b into develop Oct 23, 2019
@kcondon kcondon deleted the 6278-broken-tab-download branch October 23, 2019 20:54
@kcondon kcondon assigned kcondon and unassigned landreev Oct 23, 2019
@djbrooke djbrooke added this to the 4.18 milestone Oct 24, 2019
@pdurbin pdurbin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Download: Cannot download tab file but can download original and rdata version on develop

5 participants