Skip to content

5615 "add data" button on navbar#6338

Merged
kcondon merged 40 commits intodevelopfrom
5615-add-data-navbar
Nov 12, 2019
Merged

5615 "add data" button on navbar#6338
kcondon merged 40 commits intodevelopfrom
5615-add-data-navbar

Conversation

@landreev
Copy link
Contributor

@landreev landreev commented Nov 1, 2019

New Contributors

Related Issues

Pull Request Checklist

mheppler and others added 25 commits October 7, 2019 14:25
…nd resposnive layout improvements to top metrics/button block of dataverse and dateset pgs [ref #5615]
…cumention of Add Data workflows for new navbar and My Data link/button to user guides, fixed misc formatting issues in guides [ref #5615]
@coveralls
Copy link

coveralls commented Nov 1, 2019

Coverage Status

Coverage decreased (-0.01%) to 19.45% when pulling 81020ab on 5615-add-data-navbar into b18f706 on develop.

@djbrooke djbrooke added this to the 4.18 milestone Nov 4, 2019
@scolapasta scolapasta removed their assignment Nov 4, 2019
@landreev landreev requested a review from scolapasta November 6, 2019 22:22
@mheppler mheppler self-assigned this Nov 6, 2019
@scolapasta scolapasta removed their assignment Nov 7, 2019
@kcondon
Copy link
Contributor

kcondon commented Nov 8, 2019

issues:
-on create dataverse, throws server log error with duplicate jsf id error but works.
-initial validation errors (eg. affiliation blank) is not displayed on create likely due to dupe id error halting further processing but works second time. other validation, eg. category may work.
-changing target dataverse for creating dataverse is ignored, always created in root.
-changing target dataverse for creating dataset throws string parsing error in log and UI remains in grayed out/processing state.

@landreev
Copy link
Contributor Author

I believe the issues listed above have been fixed. Except for the last one from the list (below) - my recollection is that we were unable to reproduce that one, and that the dataset page was actually working properly. It appears to be functioning correctly now.

-changing target dataverse for creating dataset throws string parsing error in log and UI remains in grayed out/processing state.

@kcondon kcondon merged commit 9f013a7 into develop Nov 12, 2019
@kcondon kcondon deleted the 5615-add-data-navbar branch November 12, 2019 19:34
@landreev landreev restored the 5615-add-data-navbar branch November 19, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "Add Data" to navbar, plus Host Dataverse input to create dataverse/dataset forms

6 participants