Skip to content

6099 refactor index files#6349

Merged
kcondon merged 8 commits intodevelopfrom
6099-refactor-index-files
Nov 8, 2019
Merged

6099 refactor index files#6349
kcondon merged 8 commits intodevelopfrom
6099-refactor-index-files

Conversation

@sekmiller
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

Pull Request Checklist

  • Unit [tests][x] completed
  • Integration tests: None
  • Deployment requirements,None
  • Documentation NA
  • Merged latest from "develop" [branch][x] and resolved conflicts

@coveralls
Copy link

coveralls commented Nov 6, 2019

Coverage Status

Coverage increased (+0.003%) to 19.464% when pulling 27c6e2e on 6099-refactor-index-files into 5dca95d on develop.

@kcondon kcondon self-assigned this Nov 6, 2019
@djbrooke djbrooke assigned sekmiller and unassigned kcondon Nov 7, 2019
@pdurbin
Copy link
Member

pdurbin commented Nov 8, 2019

@sekmiller does 824a27f fix #3842?

@sekmiller
Copy link
Contributor Author

sekmiller commented Nov 8, 2019

This should have no effect on #3842. That has to do with indexing draft datasets, this #6099 specifically deals with FILE metadata indexing. (also the intent is not to index more, just index the same amount with consolidated logic.)

@kcondon kcondon merged commit 41acae1 into develop Nov 8, 2019
@kcondon kcondon deleted the 6099-refactor-index-files branch November 8, 2019 20:51
@kcondon kcondon assigned kcondon and unassigned sekmiller Nov 8, 2019
@djbrooke djbrooke added this to the 4.18 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactoring: Have check for whether to index files use same code as version differences

5 participants