6364 oauth2 abstract by poikilotherm · Pull Request #6365 · IQSS/dataverse

Commits on Nov 13, 2019

Remove unused leftover line from AbstractOAuth2AuthenticationProvider.getUserRecord().
poikilotherm
committed
Create unit test for OAuth2LoginBackingBean and make createState() testable.
poikilotherm
committed
Refactor OAuth2LoginBackingBean.linkFor(), moving link generation to abstracted provider. Added unit test, too.
poikilotherm
committed
Update JUnit5 libraries.
poikilotherm
committed
Make OAuth2LoginBackingBean.parseStateFromRequest() testable. Add tests.
poikilotherm
committed
Annotate OAuth2LoginBackingBean methods with TODOs for (later) refactoring.
poikilotherm
committed
Make OAuth2LoginBackingBean.exchangeCodeForToken() testable with mocked Faces context. Enhance readability.
poikilotherm
committed
Refactor OAuth2LoginBackingBeanTest: easier use with mocked authSvc and test idp
poikilotherm
committed
Add first test for OAuth2LoginBackingBean.exchangeCodeForToken()
poikilotherm
committed
OAuth2LoginBackingBean: move service to IdP logic to abstract.
poikilotherm
committed
Add test for new user branch of OAuth2LoginBackingBean.exchangeCodeForToken()
poikilotherm
committed
Add test for existing user branch in OAuth2LoginBackingBean.exchangeCodeForToken()
poikilotherm
committed
Add LocaleTest to ensure that tests run with the correct locale settings. IDEs might give us headaches and it ensures proper Maven configuration.
poikilotherm
committed
Fix unit tests failing due to mocked FacesContext
poikilotherm
committed
Refactor pom.xml to use new JUnit 5.4+ dependency package
poikilotherm
committed

Commits on Nov 21, 2019

Merge branch 'develop' into 6364-oauth2-abstract
poikilotherm
committed

Commits on Nov 22, 2019

Commits on Nov 25, 2019

Fix OAuth2 providers requiring redirect_uri parameter when requesting the access token during code flow.
poikilotherm
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

6364 oauth2 abstract#6365

6364 oauth2 abstract#6365
kcondon merged 20 commits intoIQSS:developfrom
poikilotherm:6364-oauth2-abstract

Commits on Nov 13, 2019

Remove unused leftover line from AbstractOAuth2AuthenticationProvider.getUserRecord().

Create unit test for OAuth2LoginBackingBean and make createState() testable.

Refactor OAuth2LoginBackingBean.linkFor(), moving link generation to abstracted provider. Added unit test, too.

Update JUnit5 libraries.

Make OAuth2LoginBackingBean.parseStateFromRequest() testable. Add tests.

Annotate OAuth2LoginBackingBean methods with TODOs for (later) refactoring.

Make OAuth2LoginBackingBean.exchangeCodeForToken() testable with mocked Faces context. Enhance readability.

Refactor OAuth2LoginBackingBeanTest: easier use with mocked authSvc and test idp

Add first test for OAuth2LoginBackingBean.exchangeCodeForToken()

OAuth2LoginBackingBean: move service to IdP logic to abstract.

Add test for new user branch of OAuth2LoginBackingBean.exchangeCodeForToken()

Add test for existing user branch in OAuth2LoginBackingBean.exchangeCodeForToken()

Add LocaleTest to ensure that tests run with the correct locale settings. IDEs might give us headaches and it ensures proper Maven configuration.

Fix unit tests failing due to mocked FacesContext

Refactor pom.xml to use new JUnit 5.4+ dependency package

Commits on Nov 21, 2019

Merge branch 'develop' into 6364-oauth2-abstract

Commits on Nov 22, 2019

Create new ClockUtil utility class with annotations to inject clocks via CDI

Refactor OAuth2LoginBackingBean to use java.time.Clock instead of System.currentTimeMillis(). Using CDI injection of clock via ClockUtil.

Refactore tests for OAuth2LoginBackingBeanTest to finally be non-flaky due to clock resolution of >1msec when using createState() and parseStateFromRequest().

Commits on Nov 25, 2019

Fix OAuth2 providers requiring redirect_uri parameter when requesting the access token during code flow.