Skip to content

6267 add token functions to ui#6377

Merged
kcondon merged 8 commits intodevelopfrom
6267-add-token-functions-to-ui
Nov 20, 2019
Merged

6267 add token functions to ui#6377
kcondon merged 8 commits intodevelopfrom
6267-add-token-functions-to-ui

Conversation

@sekmiller
Copy link
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

Pull Request Checklist

  • Unit [tests][x] none
  • Integration [tests][x]: NA
  • Deployment requirements, [x] None
  • Documentation NA
  • Merged latest from "develop" [branch][x] and resolved conflicts

@coveralls
Copy link

coveralls commented Nov 15, 2019

Coverage Status

Coverage decreased (-0.003%) to 19.443% when pulling 7462a4c on 6267-add-token-functions-to-ui into bf68f12 on develop.

@kcondon
Copy link
Contributor

kcondon commented Nov 18, 2019

There is no token expired indication in the UI, only the neutral expiration date: label. Discussed briefly with Mike before sending back.

@mheppler mheppler assigned sekmiller and unassigned mheppler Nov 19, 2019
@sekmiller sekmiller removed their assignment Nov 20, 2019
@kcondon kcondon self-assigned this Nov 20, 2019
@kcondon kcondon merged commit b670c16 into develop Nov 20, 2019
@kcondon kcondon deleted the 6267-add-token-functions-to-ui branch November 20, 2019 18:44
@djbrooke djbrooke added this to the 4.18.1 milestone Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add expiration date and delete button to UI for API tokens

7 participants