Skip to content

adding proposed PR template#6398

Merged
kcondon merged 3 commits intodevelopfrom
6226-pr-template
Dec 4, 2019
Merged

adding proposed PR template#6398
kcondon merged 3 commits intodevelopfrom
6226-pr-template

Conversation

@djbrooke
Copy link
Contributor

To be discussed in tech hours.

Related Issues

@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage increased (+0.1%) to 19.562% when pulling c9a3369 on 6226-pr-template into 3667976 on develop.

@pdurbin
Copy link
Member

pdurbin commented Nov 22, 2019

@djbrooke before we discuss this at tech hours, you might want to remove the existing pull request template as part of this pull request. It looks like this:

Screen Shot 2019-11-22 at 2 33 24 PM

Or you could move .github/PULL_REQUEST_TEMPLATE.md to PULL_REQUEST_TEMPLATE.md, effectively overwriting the old one. I don't think it matters if it's in that .github folder you created. By this I mean that I don't think any links will break because I don't think we link to it.

@djbrooke
Copy link
Contributor Author

Thanks @pdurbin. I don't see why this would have any impact on a discussion about the content of the new template but I'm happy to remove it at this point in time.

@djbrooke
Copy link
Contributor Author

Removed in 728106c

@pdurbin
Copy link
Member

pdurbin commented Nov 22, 2019

@djbrooke thanks. This way we can discuss if anyone cares or minds that we are introducing a .github directory.

@pdurbin pdurbin mentioned this pull request Dec 4, 2019
@scolapasta scolapasta removed their assignment Dec 4, 2019
@kcondon kcondon self-assigned this Dec 4, 2019
@kcondon kcondon merged commit c125639 into develop Dec 4, 2019
@kcondon kcondon deleted the 6226-pr-template branch December 4, 2019 19:52
@djbrooke djbrooke added this to the 4.19 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revise PR Template

5 participants