Skip to content

do not hardcode https for SWORD #6348#6399

Merged
kcondon merged 1 commit intodevelopfrom
6348-sword
Nov 25, 2019
Merged

do not hardcode https for SWORD #6348#6399
kcondon merged 1 commit intodevelopfrom
6348-sword

Conversation

@pdurbin
Copy link
Member

@pdurbin pdurbin commented Nov 22, 2019

closes #6348

@coveralls
Copy link

coveralls commented Nov 22, 2019

Coverage Status

Coverage increased (+0.003%) to 19.443% when pulling 56a2087 on 6348-sword into 495e0c6 on develop.

sekmiller
sekmiller reviewed Nov 25, 2019
View reviewed changes
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Passing to QA.

@sekmiller sekmiller removed their assignment Nov 25, 2019
@pdurbin
Copy link
Member Author

pdurbin commented Nov 25, 2019

@kcondon how to test:

@kcondon kcondon self-assigned this Nov 25, 2019
@kcondon kcondon merged commit a4ee993 into develop Nov 25, 2019
@kcondon kcondon deleted the 6348-sword branch November 25, 2019 21:12
@djbrooke djbrooke added this to the 4.19 milestone Nov 26, 2019
sekmiller added a commit that referenced this pull request Nov 26, 2019
@sekmiller
#6399 remove AJAX event from selectcheckboxmenu
3844e7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sekmiller sekmiller sekmiller left review comments

Assignees

@kcondon kcondon

Labels

None yet

Projects

None yet

Milestone

4.19

Development

Successfully merging this pull request may close these issues.

Do not hardcode https for SWORD

5 participants

@pdurbin @coveralls @sekmiller @kcondon @djbrooke