Skip to content

compare versus correct version#6420

Merged
kcondon merged 1 commit intoIQSS:developfrom
QualitativeDataRepository:IQSS/6419
Dec 2, 2019
Merged

compare versus correct version#6420
kcondon merged 1 commit intoIQSS:developfrom
QualitativeDataRepository:IQSS/6419

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 26, 2019

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

Pull Request Checklist

@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.562% when pulling 46f0987 on QualitativeDataRepository:IQSS/6419 into 7422e1c on IQSS:develop.

@scolapasta
Copy link
Contributor

@qqmeyers Thanks for these changes, they seem straightforward enough. (I do wonder if there's a better method than getLatestVersionForCopy (or if makes sense to rename that to something more clear)). Either way, I'll approve this change to QA.

@scolapasta scolapasta removed their assignment Dec 2, 2019
@kcondon kcondon self-assigned this Dec 2, 2019
@kcondon kcondon merged commit dadf117 into IQSS:develop Dec 2, 2019
@djbrooke djbrooke added this to the 4.19 milestone Dec 3, 2019
@qqmyers qqmyers deleted the IQSS/6419 branch May 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File Previews don't show in page if a draft version exists

5 participants