Can't preview in page for files in prior public dataset versions#6422
Can't preview in page for files in prior public dataset versions#6422kcondon merged 3 commits intoIQSS:developfrom
Conversation
|
@qqmyers This is ready to merge but there is a merge conflict. Can you take a look? |
|
@kcondon - I just accidentally resolved the conflict the wrong way, resulting in no changes to merge. I then went back to the branch in QDR and re-applied the change, but pushing that back to QDR doesn't appear to update this PR. I''m not sure why it isn't updating - are changes not allowed after approval? In any case, let me know how you want to resolve this: |
|
@kcondon - nevermind - dyslexia - I was trying to change 6241 instead of 6421. I've now committed the change to this branch and it should be good to go. |
|
@qqmyers Thanks! |
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.
Thanks for your contribution to Dataverse!
Related Issues
Pull Request Checklist