Conversation
pdurbin
approved these changes
Jan 9, 2020
Contributor
|
@pameyer This works for an expired token but not an invalid one, which is the other case mentioned in your ticket. Correction: your ticket title mentions both invalid and expired but your use case in the ticket specifically mentions expired due to long running jobs. Closing. |
Contributor
Author
|
@kcondon Good catch - I should've done a better job with the title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow sysadmins to log access from expired API tokens.
Which issue(s) this PR closes:
Closes #6495
Special notes for your reviewer:
Suggestions on how to test this:
curl -i -H "X-Dataverse-key: $valid_token" -X GET "http://localhost:8084/api/dataverses/:root"; edit database to set expiration date to past, repeat curl call ; check system.logDoes this PR introduce a user interface change?:
no
Is there a release notes update needed for this change?:
no
Additional documentation: