Skip to content

#6525 update weld-osgi call to match that of docker-aio et al.#6527

Merged
kcondon merged 2 commits intoIQSS:developfrom
uncch-rdmc:6525_weld-osgi-bundle
Jan 17, 2020
Merged

#6525 update weld-osgi call to match that of docker-aio et al.#6527
kcondon merged 2 commits intoIQSS:developfrom
uncch-rdmc:6525_weld-osgi-bundle

Conversation

@donsizemore
Copy link
Contributor

What this PR does / why we need it: current weld-osgi link in installation documentation is broken

Which issue(s) this PR closes:

Closes #6525

Special notes for your reviewer: bumping from SP1 to Final, but all other such calls in docs use Final

Suggestions on how to test this: spin up branch and test normally

Does this PR introduce a user interface change?: no

Is there a release notes update needed for this change?: no

Additional documentation:

@coveralls
Copy link

coveralls commented Jan 15, 2020

Coverage Status

Coverage remained the same at 19.501% when pulling 2c431f7 on OdumInstitute:6525_weld-osgi-bundle into ee91ec7 on IQSS:develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My test below is not sophisticated but it does seem to show that the old URL is broken and the new one is live:

dhcp-10-250-235-83:~ pdurbin$ curl -L 'http://central.maven.org/maven2/org/jboss/weld/weld-osgi-bundle/2.2.10.SP1/weld-osgi-bundle-2.2.10.SP1-glassfish4.jar'
501 HTTPS Required.
Use https://repo1.maven.org/maven2/
More information at https://links.sonatype.com/central/501-https-required
dhcp-10-250-235-83:~ pdurbin$
dhcp-10-250-235-83:~ pdurbin$ curl -L 'http://search.maven.org/remotecontent?filepath=org/jboss/weld/weld-osgi-bundle/2.2.10.Final/weld-osgi-bundle-2.2.10.Final-glassfish4.jar'
?wFMETA-INF/MANIFEST.MF???

@poikilotherm
Copy link
Contributor

It might be pedantic, but could you change http to https? Maven Central just turned off HTTP. https://support.sonatype.com/hc/en-us/articles/360041287334

@djbrooke
Copy link
Contributor

Thanks @poikilotherm. @donsizemore if this sounds OK to you please make the change. I was going to do it but I'm not knowledgeable in this area. :)

@djbrooke
Copy link
Contributor

@donsizemore @poikilotherm @pdurbin Is this PR still relevant or should we close?

@donsizemore
Copy link
Contributor Author

@djbrooke yes — maven throws a 501 when called via http rather than https.

@pdurbin pdurbin removed their assignment Jan 17, 2020
@kcondon kcondon self-assigned this Jan 17, 2020
@kcondon kcondon merged commit 923e795 into IQSS:develop Jan 17, 2020
@djbrooke djbrooke added this to the 4.19 milestone Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

weld-osgi-bundle-2.2.10.SP1.jar has moved.

6 participants