Create directory when saving dataset-level files#6757
Merged
Conversation
…tafile is saved, but not when saving dataset-level files. (#6739)
sekmiller
approved these changes
Mar 23, 2020
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good. Just one petty nit: it looks like there are two added lines at around 231 and 298 that are just spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In addition to the issue as described in #6739 - metadata exports failing if the dataset is published without datafiles:
A similar issue was present with dataset logos (dataset-level thumbnails): dataset logos could not be saved unless some datafiles were added to the dataset first. This is fixed in this PR also.
Which issue(s) this PR closes:
Closes #6739
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change?:
Is there a release notes update needed for this change?:
Additional documentation: