Conversation
Using only the S3 part of AWS SDK pom.xml gets lighter and speeds up builds. (And hopefully deployment times, too)
|
The integration test suite threw a number of failures on this PR because the PR is intended for Payara 5, and Jenkins is still running Glassfish4 until I get the go-ahead to flip the switch. I manually ran the same branch through EC2 and everything passed except testUningestFileViaApi, which is being handled in #6821 |
pdurbin
left a comment
There was a problem hiding this comment.
I'm moving this to QA because it seems reasonable. @poikilotherm suggests testing email and S3, which makes sense.
It's flagged as incompatible with Glassfish 4.1 but I'm not entirely sure why. He seems to be matching up Jackson versions with what the app server provides. There's a comment that says, "Should always correspond with Payara bundled version".
The "diff" is relatively small so we have trouble, we should be able to back it out without much difficultly.
|
I just saw this branch now has conflicts since the merge of #6818 |
|
@poikilotherm This works -S3, zip file. Wasn't sure what you meant when you'd said: "The whole ZIP file mangling was introduced to make mailing work. This should be tested to ensure it works." |
|
Hey @kcondon, in the AWS SDK was a properties file for AWS mail services. This was found by scanning the WAR when deploying and broke mail delivery for installations. That's why that file has been removed from the WAR manually. Mangling happend after packaging with a Maven ZIP plugin, which is now removed from the POM. So maybe the mail delivery should be tested to be sure it works and no other strange things happen. |
|
@poikilotherm OK, mail delivery has been tested and have done general smoke testing as well. I think we're good. |
What this PR does / why we need it:
@donsizemore asked me to reduce the WAR size file and I wanted to this for a long time anyway.
Now as we move to Payara 5, this is finally possible. This PR reduces the WAR size from 205 MB to 134 MB.
Which issue(s) this PR closes:
Closes #5274
Special notes for your reviewer:
No big changes. Removed completely unused
ehcachedependency.I searched the code base for other AWS SDK (besides S3) usages, but found none.
Suggestions on how to test this:
The whole ZIP file mangling was introduced to make mailing work. This should be tested to ensure it works.
The S3 storage driver should be tested to work, too, as the SDK version moved from 1.11.172 (2017) to 1.11.762 (2020).
Does this PR introduce a user interface change?:
Nope.
Is there a release notes update needed for this change?:
Nope.
Additional documentation:
I'm sure @donsizemore is happy to help testing 😉