Merged
Conversation
poikilotherm
added
Feature: Installer
Feature: Installation Guide
Feature: Admin Guide
User Role: Sysadmin
Conflicts: pom.xml (payara version .2 vs .6)
scolapasta
approved these changes
Nov 20, 2020
Contributor
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
looks good (and as discussed)
Contributor
Author
|
🥳🥳🥳🥳 Thanks for merging @kcondon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move the JDBC driver to the WAR, loading it from there instead of from the Glassfish libs.
No more manual installation, keeping all deps tight together via Maven POM. A huge benefit for testing and containers.
Which issue(s) this PR closes:
Closes #6819
Should be done after #7416
Special notes for your reviewer:
None?
Suggestions on how to test this:
Try usual database operations. If tested before #7416, check EJB timers.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
Nope. Those will be necessary for #7418.
Additional documentation:
Nada.