Merged
Conversation
…i theme styles [ref #7406]
qqmyers
added a commit
to QualitativeDataRepository/dataverse
that referenced
this pull request
Dec 5, 2020
pdurbin
approved these changes
Dec 7, 2020
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Approved. The only thing that was a head scratcher to me was the extra inline CSS but I see from the pull request description that it may go away when we update primefaces/bootstrap. I didn't actually run the code but it seems reasonable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes display/update issues around requesting access to restricted files
Which issue(s) this PR closes:
Closes #7406 and closes #7426
Special notes for your reviewer:
There is some inline style sheet code in the file-download-button-fragment that will hopefully go away when we update prime faces/Bootstrap.
Suggestions on how to test this:
All manner of requesting access with and without terms of access on the dataset page and file page including datasets where requesting access is not allowed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
no
Additional documentation: