7534 user page null pointer exception#7562
Merged
Conversation
scolapasta
approved these changes
Feb 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
sets a default tab (account info) for the dataverse user page to avoid getting the null pointer in page init
Which issue(s) this PR closes:
Closes #7534
Special notes for your reviewer:
Suggestions on how to test this:
Try to go to the user page without a param for selectTab as in https://demo.dataverse.org/dataverseuser.xhtml
It should redirect to Account info it the user is logged in or the log in page if not. (and to account info upon logging in)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Somewhat arbitrary choice of "accountInfo" as default. Left a note for the design team to OK. At request of the Design Team, we moved the tab order to reflect that Account Info is the default.
Is there a release notes update needed for this change?:
Additional documentation: