6685 truncate methods - dataset pg summary block description#7644
Merged
6685 truncate methods - dataset pg summary block description#7644
Conversation
mheppler
changed the title
…ater than 250px in height [ref #6685]
Contributor
Author
|
Much appreciation to @scolapasta for assisting with the new |
scolapasta
approved these changes
Mar 8, 2021
Contributor
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
Looks good. If at some point the summary section gets "updated" by ajax, this will likely break, but the logic to handle was more complicated than currently needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Various UI display issues have been reported when large blocks of text and HTML are displayed in the Description field of the summary block section, under the citation and above the tabs on the dataset pg. Added truncation plugin and custom js, css to improve displaying larger descriptions.
Which issue(s) this PR closes:
Closes #6685 Truncate methods: checksums, long summary metadata fields
Special notes for your reviewer:
Suggestions on how to test this:
NOTE... there is a dataset publish bug that breaks tooltips and other js rebind functions (like truncate), see the new issue opened to report this, Dataset Publish - Missing success msg + broken tooltips and other js rebind functions + unfortunate "DRAFT was not found" on page reload #7653.
Put whatever text and HTML into your dataset description that the system allows (I put some sample dataset links in one of my progress comments on the original issue)... this will chop it down to a respectable size for browsing... also, don't forget to SHIFT+RELOAD if you're seeing any weird stuff the first go through... ENJOY!!!!
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: