Conversation
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
Looks good - just some questions to consider.
conf/docker-aio/0prep_deps.sh
Outdated
| #wget https://archive.apache.org/dist/lucene/solr/7.3.0/solr-7.3.0.tgz -O solr-7.3.0dv.tgz | ||
| wget https://archive.apache.org/dist/lucene/solr/7.7.2/solr-7.7.2.tgz -O solr-7.7.2dv.tgz | ||
| cd dv/deps/ | ||
| wget https://archive.apache.org/dist/lucene/solr/8.8.2/solr-8.8.1.tgz -O solr-8.8.1dv.tgz |
There was a problem hiding this comment.
8.8.2 directory, but 8.81 version?
| @@ -0,0 +1,11 @@ | |||
| ### Solr Update | |||
|
|
|||
| With this release we upgrade to the latest available stable release in the Solr 8.x branch. We recommend a fresh installation of Solr 8.8.1 (the index will be empty) | |||
There was a problem hiding this comment.
Do we want to consider porting the old index and incremental index all? (what have we done for past Solr upgrades?)
There was a problem hiding this comment.
I didn't consider that. This is close to the release note we used when we went to 7.7.2
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
I only took a quick look but I think I found a typo in the Vagrant script.
Overall, I'm glad that both Vagrant and docker-aio were updated.
scripts/vagrant/setup-solr.sh
Outdated
| su $SOLR_USER -s /bin/sh -c "cp /dataverse/conf/solr/7.7.2/solrconfig.xml $SOLR_HOME/solr-7.7.2/server/solr/collection1/conf/solrconfig.xml" | ||
| su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME/solr-7.7.2 && bin/solr start && bin/solr create_core -c collection1 -d server/solr/collection1/conf/" | ||
| su $SOLR_USER -s /bin/sh -c "cp /dataverse/downloads/solr-8.8.1.tgz $SOLR_HOME" | ||
| su $SOLR_USER -s /bin/sh -c "cd $SOLR_HOME && tar xfz solr-78.8.1.tgz" |
There was a problem hiding this comment.
no. good catch.
thanks.
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Should we update the following in pom.xml?
<dependency>
<groupId>org.apache.solr</groupId>
<artifactId>solr-solrj</artifactId>
<version>7.7.2</version>
</dependency>
|
Thanks @pdurbin @scolapasta for the reviews (and @sekmiller for the PR). Is there anything left here or can we smash the approve button? |
scolapasta
left a comment
scolapasta
left a comment
There was a problem hiding this comment.
OK, after discussing at tech hours, we decided we're ok with the release notes, as is.
Fixed in ed6f575. Moving back to QA. |
|
Issues found so far:
|
6 participants
What this PR does / why we need it:
Revises the doc and adds release notes related to upgrading Solr
Which issue(s) this PR closes:
Closes #7373
Special notes for your reviewer:
No code to review. I followed the instructions for installing Solr while using the latest stable release (8.8.1). Normal processing of indexes including reindex all for my small local db worked without a hitch. Verify that I caught all the places where the doc and install scripts need to be updated.
Suggestions on how to test this:
Install and run the new version of solr. verify that indexing works as expected
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
doc/release-notes/7373-solr-upgrade.md
Additional documentation:
Doc changes were made to prerequisites, dev environment, and metadata sections