Merged
Conversation
sekmiller
approved these changes
Mar 8, 2021
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks reasonable using an existing query and map for improved performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds back indexing of variable labels and fields added via the Data Curation Tool
Which issue(s) this PR closes:
Closes #6545
Special notes for your reviewer:
The change was just to reduce the number of queries from one per variable to 1 (then put that into a Map).
Suggestions on how to test this:
Test and compare performance of indexing, especially index all. Indexing should take a little longer than current (because) it is indexing more, but a reasonable percentage more. In my testing, for example, 1 dataset took just under a second before this change and just over a second after (with the original variable metadata indexing it took 10 seconds).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Yes, installation should reindex to catch variable metadata (the plan is to get this into the same release as Solr upgrade).
Additional documentation: