Skip to content

#7666: use the production citation.tsv in test, remove the copy store…#7671

Merged
kcondon merged 1 commit intoIQSS:developfrom
pkiraly:7666-remove-citation-from-test-resources
Mar 11, 2021
Merged

#7666: use the production citation.tsv in test, remove the copy store…#7671
kcondon merged 1 commit intoIQSS:developfrom
pkiraly:7666-remove-citation-from-test-resources

Conversation

@pkiraly
Copy link
Copy Markdown
Member

@pkiraly pkiraly commented Mar 10, 2021

use the production citation.tsv in test, remove the copy stored in test resources.

What this PR does / why we need it: An AdminIT integration test uses a copy of citation.tsv file. It is a burden for the maintainer of the file, since he needs to update both files. This PR removes this copy, and change test to use the original file.

Which issue(s) this PR closes: #7666

Closes #7666

Special notes for your reviewer:

Suggestions on how to test this: Run integration tests as it is described in conf/docker-aio/readme.md

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?: no

Additional documentation: no

@pkiraly
Copy link
Copy Markdown
Member Author

pkiraly commented Mar 10, 2021

I ping @scolapasta as he requested this change.

@djbrooke
Copy link
Copy Markdown
Contributor

Thanks @pkiraly - I added this to the review column, so someone will take a look soon!

@kcondon kcondon self-assigned this Mar 11, 2021
@kcondon kcondon merged commit c851055 into IQSS:develop Mar 11, 2021
@djbrooke djbrooke added this to the 5.4 milestone Mar 11, 2021
@pkiraly
Copy link
Copy Markdown
Member Author

pkiraly commented Jun 24, 2021

This PR was developed by Göttingen eResearch Alliance, Germany, and funded by SSHOC, "Social Sciences and Humanities Open Cloud". SSHOC has received funding from the European Union’s Horizon 2020 project call H2020-INFRAEOSC-04-2018, grant agreement #823782.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove citation.tsv from the test resources, and use the production file instead

4 participants