Merged
Conversation
pdurbin
approved these changes
Mar 22, 2021
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Looks good. Seems to be straightforward. I didn't run the code myself.
This was referenced Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds a note to the dataset save success message reminding the user to publish their dataset (or submit it for review, as applicable) because a surprising number of users leave their dataset versions in DRAFT.
Which issue(s) this PR closes:
Closes #7675
Special notes for your reviewer:
Suggestions on how to test this:
See that all save dataset success messages have publish/submit reminders that vary by dataset state and user perms.
See google doc attached to the original ticket for wording.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: