Skip to content

Comments

add guidelines on research code in User Guide#7717

Merged
kcondon merged 7 commits intoIQSS:developfrom
atrisovic:docs-research-code
Apr 29, 2021
Merged

add guidelines on research code in User Guide#7717
kcondon merged 7 commits intoIQSS:developfrom
atrisovic:docs-research-code

Conversation

@atrisovic
Copy link
Member

What this PR does / why we need it:

It adds guidelines on research code in the User Guide. We need it because we don't have guideline on that so far.

Suggestions on how to test this:

All links should work. The text should be understandable to a layperson.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Figure:

Screen Shot 2021-03-23 at 5 56 04 PM

@atrisovic
Copy link
Member Author

I suggest @poikilotherm, @jggautier, @pdurbin have a look at the text.

PS: I expect that we'll have updates on the section with time, but this should be a viable start.

@jggautier
Copy link
Contributor

@atrisovic, I've reviewed this addition to the guides. I think it's great and is very clear even to someone like me with limited experience publishing research code. I wouldn't be able to contribute anything substantive but could contribute some minor prose style changes.

@pameyer
Copy link
Contributor

pameyer commented Mar 24, 2021

It may be out of scope for this PR; but it might be worth considering recommending that depositors provide (at least minimal) information about the execution environment they used to run the code.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the content yet but left some suggestions to capitalize headings to match our house style.

- Data File Citation (currently in either RIS, EndNote XML, or BibTeX format);
- All of the above, as a zipped bundle.

Research code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Research code
Research Code

Our "house style" is to capitalizing all headings.

- Consider testing your code in a clean environment before sharing it, as it could help you identify missing files or dependencies.
- Consider providing notes (in the README) on the expected code outputs or adding tests in the code, which would ensure that its functionality is intact.

General guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
General guidelines
General Guidelines

@atrisovic atrisovic force-pushed the docs-research-code branch from 867a70f to b569c3e Compare March 24, 2021 18:12
Copy link
Contributor

@djbrooke djbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @poikilotherm for the tag and nice work @atrisovic ! It looks like there are some other people tagged so I won't approve quite yet, but consider this a 👍 from me.

@4tikhonov
Copy link
Contributor

Fine with me as well, nice first steps!

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good. I believe I have found a few formatting errors. I didn't test them locally.

@atrisovic atrisovic force-pushed the docs-research-code branch from f0c12ae to b569c3e Compare March 29, 2021 15:45
Copy link
Contributor

@poikilotherm poikilotherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @atrisovic for getting this party started. I have a few thoughts, but no show stoppers.

@atrisovic
Copy link
Member Author

I incorporated all suggestions and tested the page locally. I think it's ready to be merged 😄

@kcondon kcondon self-assigned this Apr 29, 2021
kcondon and others added 3 commits April 29, 2021 11:20
Removing lines 196-197, 208-209 to resolve warning: Warning, treated as error:
/home/worker/workspace/guides.dataverse.org/doc/sphinx-guides/source/user/dataset-management.rst:200: SEVERE: Title level inconsistent:
@kcondon kcondon merged commit dd83396 into IQSS:develop Apr 29, 2021
@atrisovic atrisovic deleted the docs-research-code branch April 29, 2021 19:58
@djbrooke djbrooke added this to the 5.5 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants