Skip to content

Comments

dirindex doc should show use of DOI for end users#7800

Merged
kcondon merged 4 commits intoIQSS:developfrom
mankoff:minor-doc-edit
Apr 23, 2021
Merged

dirindex doc should show use of DOI for end users#7800
kcondon merged 4 commits intoIQSS:developfrom
mankoff:minor-doc-edit

Conversation

@mankoff
Copy link
Contributor

@mankoff mankoff commented Apr 14, 2021

Minor doc edit to show end-users how they can use new dirindex API using DOI rather than dataset ID.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mankoff overall, looks great! I made a couple suggestions.

mankoff and others added 2 commits April 14, 2021 09:34
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@mankoff
Copy link
Contributor Author

mankoff commented Apr 14, 2021

I committed the suggested changes.

@scolapasta
Copy link
Contributor

@mankoff or @pdurbin did you see the change request made? It should be small, and we can approve once it's consistent.

${ID} is data set ID. ${PERSISTENT_ID} is DOI
Copy link
Contributor Author

@mankoff mankoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24 changed to ${ID} as per request.

@kcondon kcondon self-assigned this Apr 23, 2021
@kcondon kcondon merged commit 9486b5b into IQSS:develop Apr 23, 2021
@djbrooke djbrooke added this to the 5.5 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants