-
Notifications
You must be signed in to change notification settings - Fork 536
Make Production Place repeatable and facetable, make Series repeatable #7810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
11a3e94
Merge pull request #1 from IQSS/develop
philippconzett d8ffe4c
Update citation.tsv
philippconzett f3334f5
Update citation.tsv
philippconzett 8c21211
Merge branch 'IQSS:develop' into develop
philippconzett 7f61654
Merge branch 'develop' into pr/7810
djbrooke 6060d5f
adding release note
djbrooke 35ff4a5
Merge branch 'develop' into pr/7810
djbrooke badf7d6
fixing error and rerunning tests
djbrooke 83e8cef
Merge branch 'develop' into pr/7810
djbrooke d83ba71
update release note
djbrooke 5c8ff66
updating release note, updating schema
djbrooke 4509dea
update schema.xml from API output #7810
pdurbin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| ## Upgrade Instructions | ||
|
|
||
| X\. Reload Citation Metadata Block: | ||
|
|
||
| `wget https://github.com/IQSS/dataverse/releases/download/v5.X/citation.tsv` | ||
| `curl http://localhost:8080/api/admin/datasetfield/load -X POST --data-binary @citation.tsv -H "Content-type: text/tab-separated-values"` | ||
|
|
||
| X\. Update Solr schema.xml. | ||
|
|
||
| `/usr/local/solr/solr-8.8.1/server/solr/collection1/conf` is used in the examples below as the location of your Solr schema. Please adapt it to the correct location, if different in your installation. Use `find / -name schema.xml` if in doubt. | ||
|
|
||
| Xa\. Replace `schema.xml` with the base version included in this release. | ||
|
|
||
| ``` | ||
| wget https://github.com/IQSS/dataverse/releases/download/v5.X/schema.xml | ||
| cp schema.xml /usr/local/solr/solr-8.8.1/server/solr/collection1/conf | ||
| ``` | ||
|
|
||
| For installations that are not using any Custom Metadata Blocks, **you can skip the next step**. | ||
|
|
||
| Xb\. For installations with Custom Metadata Blocks | ||
|
|
||
| Use the script provided in the release to add the custom fields to the base `schema.xml` installed in the previous step. | ||
|
|
||
| ``` | ||
| wget https://github.com/IQSS/dataverse/releases/download/v5.X/update-fields.sh | ||
| chmod +x update-fields.sh | ||
| curl "http://localhost:8080/api/admin/index/solr/schema" | ./update-fields.sh /usr/local/solr/solr-8.8.1/server/solr/collection1/conf/schema.xml | ||
| ``` | ||
|
|
||
| (Note that the curl command above calls the admin api on `localhost` to obtain the list of the custom fields. In the unlikely case that you are running the main Dataverse Application and Solr on different servers, generate the `schema.xml` on the application node, then copy it onto the Solr server) | ||
|
|
||
| X\. Run a ['Reindex in Place'](https://guides.dataverse.org/en/5.X/admin/solr-search-index.html#reindex-in-place) as described in the Dataverse Guides. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want the subfields of "series" to be multivalued as well. Please check out this diff:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the subfields of series in 4509dea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or wouldn't it make more sense to change Series to a complex field, such as Author? I guess this would mean:
series
allowmultiples: TRUE
seriesName
allowmultiples: FALSE
seriesInformation
allowmultiples: FALSE