Demo - Reviewdog - Demo - DO NOT MERGE#7886
Closed
poikilotherm wants to merge 17 commits intoIQSS:developfrom
Closed
Demo - Reviewdog - Demo - DO NOT MERGE#7886poikilotherm wants to merge 17 commits intoIQSS:developfrom
poikilotherm wants to merge 17 commits intoIQSS:developfrom
Conversation
…6070 Also switch from bulk imports of commons.lang3.* to single class style. Fixing for other parts like java.util, too.
IQSS#6070 Apache Commons Lang3 3.12.0 moved `StringEscapeUtils` to Apache Commons Text. Also, escapeHtml() and escapeXml() from Apache Commons Lang (v2) have been renamed to escapeHtml4() and escapeXml10() with v3.0
... to be safe. (IQSS#6070)
poikilotherm
added
the
Component: Code Infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
THIS IS A DEMO - DO NOT MERGE
Just to give y'all an impression how this might ease reviews by finding the chore work to be done by and contributor. It should make it easier to keep new contributions inline with what we as a community agree on for coding rules, while not generating any noise for existing issues (which was disliked in the past).
Which issue(s) this PR closes:
Relates to #6070 and #7801
Special notes for your reviewer:
Look at @reviewdog barking at the violating lines.
Doggo is not yet part of this repo, so the access token still has no write permission to leave a comment (as with poikilotherm#441)
Suggestions on how to test this:
You could add more
checkstylerules or introduce other matching changes and have that puppy bark at 'em.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
Nope.
Additional documentation:
None.