Implement usage of user supplied handle for authentication. This is an optional parameter.#7951
Implement usage of user supplied handle for authentication. This is an optional parameter.#7951kcondon merged 6 commits intoIQSS:developfrom cookie33:7949-HandleAuthHandle
Conversation
…n optional parameter.
…o null then use it.
|
Hi @cookie33 thanks for the PR! Jenkins is saying that the commit can't be built: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-7951/5/display/redirect Can you take a look? Thanks! |
…racter when it is being assigned.
|
@djbrooke. The Maven unit tests are failing. But I fail to see why? What did I do wrong? Or could have done better. |
|
Thanks @poikilotherm and apologies to @cookie33 for the confusion! |
|
Thanks for the updates. |
| By default this setting is absent and the Dataverse Software assumes it to be not set. | ||
|
|
||
| ``curl -X PUT -d '<prefix/<suffix>' http://localhost:8080/api/admin/settings/:HandleAuthHandle`` | ||
|
|
There was a problem hiding this comment.
just an inconsistency with the '<prefix/suffix>' in the description/example. please remove the "<" in the example
There was a problem hiding this comment.
HI,
I modified the documentation to be more clear with a real world example.
A new commit was done..
Greetings..
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
Looks good overall. Just one minor change in the doc. Also please update with the latest from the dev branch and make sure there are no conflicts. Thanks!
|
Thanks @cookie33! We'll take another look! |
6 participants
Implement usage of user supplied handle for authentication. This is an optional parameter.
What this PR does / why we need it:
It fixes the issue if the Dataverse user can not use the default supplied handle to authorise
Which issue(s) this PR closes:
Closes #7949
Special notes for your reviewer: Not tested yet. We do not run Dataverse. We are a handle provider.
Suggestions on how to test this: try it with an existing Dataverse installation which talks to a handle server. Set the new optional parameter HandleAuthHandle to
0.NA/<prefix>. Or if it is an independent handle server to<prefix>/ADMIN.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No user interface change
Is there a release notes update needed for this change?:
yes. To state that a new parameter has been introduced.
Additional documentation: