7980 enhance data source definition#7983
Closed
poikilotherm wants to merge 6 commits intoIQSS:developfrom
Closed
Conversation
…IG. IQSS#7980 Previously, with Dataverse software 5.3, the option to configure the database connection has been moved into the codebase. Admins can set details via MicroProfile Config. With updating to Payara 5.2021.4, we can provide default values for the connection details. Before, this had been tried with adding them to META-INF/microprofile-config.properties. However, this is not possible due to the timing of resource creation in the application server vs. reading the properties file. IQSS#7980
As requested by @pdurbin, the long list was quite overwhelming. It's now damped down to 12 options in 3 subsubsections of the docs.
poikilotherm
force-pushed
the
7980-enhance-dsd
branch
from
859a56f to
02342dc
Compare
Contributor
Author
|
Looks like this will stay in "draft" for another while, until payara/Payara#5322 is resolved, landed in a new release AND we update to that or a later release. 🙈 (Positive: I learned a lot more about Arquillian today 😆 ) Tagging @kcondon here for the lulz. |
Merged
Contributor
Author
|
Closed in favor of all new #8915 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create real defaults for the database connection, enable configuring advanced settings, add docs
and fix 5.3 release notes.Which issue(s) this PR closes:
Closes #7980
Special notes for your reviewer:
The release docs of 5.3 do not need to be changed. The statements on how to upgrade etc are working just fine.
Only in a few occasions people might have hit the regression.
Suggestions on how to test this:
asadmin create-system-properties "dataverse.db.log-jdbc-calls=true"Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope.
Is there a release notes update needed for this change?:
🔋 included.
Additional documentation:
None.