Conversation
sekmiller
reviewed
Jul 27, 2021
Contributor
sekmiller
left a comment
sekmiller
left a comment
There was a problem hiding this comment.
The Payara section looks good.
qqmyers
reviewed
Jul 27, 2021
qqmyers
reviewed
Jul 27, 2021
qqmyers
reviewed
Jul 27, 2021
…unning the commands as root, etc.; these were originally added in 5.4). #8012.
landreev
reviewed
Jul 27, 2021
Contributor
|
In general, kudos for the idea of not repeating the same stuff in multiple places. |
Contributor
|
Please note my comment on #8012 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have to talk about all the cool stuff we've been building!
Which issue(s) this PR closes:
Closes #8012
Special notes for your reviewer:
Suggestions on how to test this:
Take a look, especially at the technical areas. :)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No!
Is there a release notes update needed for this change?:
👓
Additional documentation:
None