Conversation
landreev
reviewed
Oct 4, 2021
landreev
reviewed
Oct 4, 2021
landreev
reviewed
Oct 4, 2021
pdurbin
reviewed
Oct 4, 2021
Member
pdurbin
left a comment
There was a problem hiding this comment.
I left a few comments but overall this is looking good.
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
Contributor
Author
qqmyers
reviewed
Oct 7, 2021
qqmyers
reviewed
Oct 7, 2021
qqmyers
reviewed
Oct 7, 2021
| - Users retrieving large guestbooks over the API will experience fewer failures (Issue #8073, PR #8084) | ||
| - Users will now be able to set a language for metadata entry for datasets (Issue #7388, PR #7958) | ||
| - Administrators will now be able to set a language for metadata exports at the document or element level (Issue #7388, PR #7958) | ||
| - Administrators will now be able to specify the language of controlled vocabulary items (Issue #6751, PR #7959) |
Member
There was a problem hiding this comment.
"DDI metadata exports will include values for controlled vocabulary items using the metadata language defined for the dataset and will include a second value in the Dataverse instance's default language (if different)."?
I.e. - if the Dataverse is set up to display French and a given Dataset defines English as the metadata lang, the controlled vocab entries in the DDI export will include a French lang element and an English one. If the Dataset uses French for the metadata language, there would only be one entry in this case (since the Dataverse instances uses French).
I
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
5.7 is upon us.
Which issue(s) this PR closes:
Closes #8112
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: