Skip to content

IQSS/8252: Correct error response to 403/forbidden in test#8253

Merged
kcondon merged 1 commit intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8109-separate-managefilepermissions
Nov 22, 2021
Merged

IQSS/8252: Correct error response to 403/forbidden in test#8253
kcondon merged 1 commit intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/8109-separate-managefilepermissions

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Nov 22, 2021

What this PR does / why we need it: #8174 included a fix to report a request to the api/access/datafile/{id}/listRequests endpoint with a bad apikey to return 403/Forbidden instead of 400/Bad Request. The related AccessIT test wasn't updated to match.

Which issue(s) this PR closes:

Closes #8252

Special notes for your reviewer:

Suggestions on how to test this: Just run the IT tests / the AccessIT tests in particular.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: no

Is there a release notes update needed for this change?:

Additional documentation:

@djbrooke djbrooke added this to the 5.9 milestone Nov 22, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 18.953% when pulling 675c882 on GlobalDataverseCommunityConsortium:IQSS/8109-separate-managefilepermissions into f0d4604 on IQSS:develop.

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it needs to do. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration test failures in develop

5 participants