only run regex replaces on DBs with UTF8 encoding #8278#8279
Merged
Conversation
Contributor
|
@pdurbin For the PR, you should be able to just use "replace" function instead of reg_exp replace and not need all the extra logic checking encoding. |
Member
Author
|
@scolapasta I tried just |
scolapasta
approved these changes
Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Deployment fails if the encoding is
SQL_ASCII. Here we only run the regex replaces if the database isUTF8.Which issue(s) this PR closes:
Closes #8278
Special notes for your reviewer:
Devs will need to delete the old "V5.8.0.2__8018-invalid-characters.sql" SQL migration from their flyway table because the checksum is changing.
Suggestions on how to test this:
Make sure the replaces still happen
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
No