Missing anonymization in files version table for anon PrivateURLs#8299
Merged
kcondon merged 1 commit intoIQSS:developfrom Dec 9, 2021
Conversation
verified that the names withheld bundle entry already exists.
scolapasta
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This PR removes contributor names from the version table on the files page when you access the dataset with an anonymized PrivateURL
Which issue(s) this PR closes:
Closes #8298
Special notes for your reviewer:
Suggestions on how to test this: Use a privateURL with anonymization on and look in the contributor column of the file page version table - you should see that the names are withheld. This is how it already works for the dataset page version table so you can compare/verify - if you see names in the dataset page version table, there's probably some config issue with the PrivateURL.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: could/should notify people of the leak?
Additional documentation: