Conversation
- CC BY is now available for new installations. - New "Configuring Licenses" section added to Installation Guide. - JSON files for all Creative Commons licenses are downloadable. - URL fixed in licenseCC-BY-NC-ND-4.0.json. - Various cleanup of typos, formatting, etc.
landreev
approved these changes
Feb 23, 2022
Contributor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pull request #7920 added multiple license support but we could take it a bit farther by providing new installations additional licenses beyond CC0 and by providing more documentation on how to manage licenses and add popular licenses such as the ones from Creative Commons.
To this end:
Which issue(s) this PR closes:
Closes #8347
Special notes for your reviewer:
I tried to take a relatively light touch on existing docs. I used the new "Configuring Licenses" section as a way to weave them together. However, I was tempted to change the following:
/api/licensesfrom "Admin" to their own section ("Licenses"). They really aren't part of the Admin API. Let me know and I'll include this change.Also, I used "CC0 1.0" instead of "CC0" in anticipation of pull request #8413 being merged.
Suggestions on how to test this:
Check to make sure of the following:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No. I think we have enough release notes docs for multiple licenses. We can tweak them as needed at release time. The CC BY addition is only for new installations, not upgrades.
Additional documentation:
None.