Merged
Conversation
(first value gets the real label, repeat values get the aria label 'Additional Entry')
Conflicts: src/main/webapp/dataset.xhtml
a link is empty in the dialog if the dataset doesn't have a grandparent dataverse, which is also the case when you won't need the dialog, so just don't render it. for compute - adding a facet gives the header a value
since the panel includes info from the fileMetadata which is blank otherwise, it seems odd to render it when no fileMetadata is sent as a param. Still possible that something requires that, but haven't seen anything yet. Conflicts: src/main/webapp/file-info-fragment.xhtml
scolapasta
approved these changes
Mar 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Adds additional Accessibility fixes/enhancements from QDR
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer: There's more discussion in #8321. For this PR, the primary tool to find issues was WebAIM WaVE. As mentioned elsewhere, I'm hopeful that there are few enough issues after this that we can close old accessibility issues and create new ones for any that remain. The main source at this point would be PrimeFaces so the PrimeFaces 11 update could help there.
Also note that this removes an old worldmap dialog and a hidden input related to deaccessioning that appears to have stopped being used 5+ years ago.
Suggestions on how to test this: Verify standard Dataverse functionality. Probably worth trying a deaccession since I did remove what I think is an unused hidden input there. Otherwise, the changes should primarily be to labels that don't show in the standard UI. I think there's one minor color change in a breadcrumb caret. It could also be worthwhile to install the Wave tool mentioned above into Firefox and verify before/after that the number of issues descreases.
Does this PR introduce a user interface change? If mockups are available, please link/include them here: ~no - see test note
Is there a release notes update needed for this change?:
Additional documentation: