Merged
Conversation
Merged
Contributor
|
Issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Testing of other PRs uncovered a couple cases where example json/json-ld input files/inline code in the guides were out of date w.r.t. the multi-license PR in 5.10. This PR updates those examples, fixes a minor logging issue also discovered in testing, and updates a couple test classes where we were using a variant of the CC0 URI (ending in a terminal '/' ) - the tests weren't wrong per se, but we aren't using that form of the URL anymore in the code/examples.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Suggestions on how to test this: When #8491 is merged, let me know and I can update this PR (there are changes to the same example file). Confirm that the json import examples in the guides work and the data-migration.jsonld example file. Verify the Unit tests still work (automated).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: