Skip to content

IQSS/multilicense_fixes#8493

Merged
kcondon merged 6 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/mLicense_fixes
Mar 16, 2022
Merged

IQSS/multilicense_fixes#8493
kcondon merged 6 commits intoIQSS:developfrom
GlobalDataverseCommunityConsortium:IQSS/mLicense_fixes

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Mar 15, 2022

What this PR does / why we need it: Testing of other PRs uncovered a couple cases where example json/json-ld input files/inline code in the guides were out of date w.r.t. the multi-license PR in 5.10. This PR updates those examples, fixes a minor logging issue also discovered in testing, and updates a couple test classes where we were using a variant of the CC0 URI (ending in a terminal '/' ) - the tests weren't wrong per se, but we aren't using that form of the URL anymore in the code/examples.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this: When #8491 is merged, let me know and I can update this PR (there are changes to the same example file). Confirm that the json import examples in the guides work and the data-migration.jsonld example file. Verify the Unit tests still work (automated).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 18.864% when pulling 31a2862 on GlobalDataverseCommunityConsortium:IQSS/mLicense_fixes into 0aaf203 on IQSS:develop.

Copy link
Contributor

@landreev landreev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - I'm going to approve it; let's keep an eye on it, and depending on which one is merged first, this one or #8491, make sure to update the other branch...

@kcondon kcondon self-assigned this Mar 15, 2022
@pdurbin pdurbin mentioned this pull request Mar 15, 2022
@pdurbin pdurbin added this to the 5.10 milestone Mar 15, 2022
@kcondon
Copy link
Contributor

kcondon commented Mar 16, 2022

Issues:

  1. Getting 400 error when using new example to test dataset migration, server.log says: "Couldn't find a license for: https://creativecommons.org/publicdomain/zero/1.0]]" this is the response on the command line: "{"status":"ERROR","code":400,"message":"Bad Request. The API request cannot be completed with the parameters supplied. Please check your code for typos, or consult our API guide at http://guides.dataverse.org.","requestUrl":"http://localhost:8080/api/v1/dataverses/root/datasets/:startmigration","requestMethod":"POST"}" [Update 2] I was incorrect in my earlier statement, there is a cc0 item in the list, was thinking of custom terms. So, this error stands.

@kcondon kcondon merged commit dbca4ab into IQSS:develop Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants