Conversation
Fix missing padding for footer.
pdurbin
approved these changes
Mar 31, 2022
Member
There was a problem hiding this comment.
Seems ok and in line with the comment @qqmyers made about how maybe it should be footer instead of #footer at https://github.com/IQSS/dataverse/pull/8507/files/457ec20986f07be4640eddbf7fefb4b23de6231c#r830171038
I did a little testing. There's more vertical whitespace with this pull request, which I think is the goal. I also enabled a custom footer and checked that the logo isn't pinned.
Before (develop)
After (this pull request)
With custom footer (logo isn't pinned, which was the problem in #8506 and fixed in PR #8507)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing padding for footer.
What this PR does / why we need it:
Which issue(s) this PR closes:
Closes #8564
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
It fixes a slight issue introduced in a recent build, not yet released, where the padding between the footer and body of the page is missing.
Is there a release notes update needed for this change?:
Additional documentation: