Fix sorting order of licenses by id with default license at the top#8567
Merged
kcondon merged 5 commits intoIQSS:developfrom Apr 8, 2022
Merged
Fix sorting order of licenses by id with default license at the top#8567kcondon merged 5 commits intoIQSS:developfrom
kcondon merged 5 commits intoIQSS:developfrom
Conversation
Contributor
Author
|
I noticed that a check failed. I tried the 'Details' link, but the link does not work for me. I get a connection timeout error for jenkins.dataverse.org. |
Contributor
No worries @Kris-LIBIS - Jenkins is hidden behind curtains of fail2ban because of bot attacks. The failing test is not related to you, it's been taken care of in #8557. You might want to update this branch with latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the random sorting of licenses in the drop-down when a license record is edited. Using the API to activate a license or setting it as default will also edit the license record.
Which issue(s) this PR closes:
Does not really close #8554, but it solves the most important problems with the issue. When a final and more elaborate solution is agreed upon, the modifications in this PR will need to be revisited anyway.
Special notes for your reviewer:
The PR is not perfect (see the issue discussions), but licenses should remain at the same position with the exception of the default license, which should appear at the top.
Suggestions on how to test this:
Add multiple licenses and check the order of the licenses. Then deactivate and activate licenses, set different default licenses and check the license order in the drop-down.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No new UI elements, but influences the order of the content of the license drop-down.
Is there a release notes update needed for this change?:
Not at this point. This fixes the application to behave as expected.
Additional documentation: