Merged
Conversation
scolapasta
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This consolidates the calls to rebind components to the Dataverse template page from the individual buttons/methods.
Which issue(s) this PR closes: Doesn't actually fully close this. As discussed, this is a pilot which just removes the rebind from buttons on the dataset page and widgets. If this is successful/merged, we will handle the rest of the pages in another PR.
Closes #7565 improve Primefaces/Bootstrap interaction. not fully as noted above
Special notes for your reviewer: Again this is fully implemented only on the dataset page and widgets
Suggestions on how to test this: Please verify that all interactions on the dataset page work as expected
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: