TDL/7493 Improve BagGenerator failure handling#8609
Merged
kcondon merged 5 commits intoIQSS:developfrom May 27, 2022
Merged
Conversation
…erator_threads_configurable
…Gnerator_failure_handling
landreev
approved these changes
May 25, 2022
TDL/7493-improve_BagGnerator_failure_handling
…Gnerator_failure_handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The prior code did not correctly close connections when a non-200 response was received. Due to this, repeated failures could temporarily exhaust the pool of threads. While this was first seen with 'bad' datasets, e.g. ones where the physical files have been deleted, it would happen if there were temporary network outages as well. The PR correctly closes the stream in those cases.
It also adds a couple minor fixes/enhancements:
Which issue(s) this PR closes:
Closes #8603
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: planning an aggregate Bag/archiving change notes rather than per PR.
Additional documentation: